FAQFAQ   SearchSearch   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

#74 - [Feature] Merit Rework (Added)

 
Post new topic   Reply to topic    Drop Shock Forum Index -> Player Council - Closed Tickets
View previous topic :: View next topic  
Author Message
Vanoi
Site Admin


Joined: 25 Aug 2005
Posts: 1403
Location: Avoiding You (The Void)

PostPosted: Tue Feb 26, 2013 9:55 am    Post subject: #74 - [Feature] Merit Rework (Added) Reply with quote

https://sourceforge.net/p/dropshock/tickets/74/

Approved: 6 votes.

Increases merit chance by 5% for every level you don't gain a merit.

Redid the roll mechanic so it doesn't auto-fail if you roll a merit you already have.

By: Lark
_________________
The person who will go to great lengths to fight boredom...


Last edited by Vanoi on Mon Mar 25, 2013 2:19 pm; edited 6 times in total
Back to top
View user's profile Send private message Send e-mail MSN Messenger
Slayer_666
Council Member


Joined: 20 Dec 2012
Posts: 226

PostPosted: Tue Feb 26, 2013 9:56 am    Post subject: Reply with quote

YAY

Slayer
Back to top
View user's profile Send private message
Dark Leth
Council Member


Joined: 05 Jul 2005
Posts: 1498

PostPosted: Tue Feb 26, 2013 3:08 pm    Post subject: Reply with quote

Lets wait for the three day hearing period to consider pushing it but I'm tentatively voting aye.
Back to top
View user's profile Send private message
Walterohdim
Site Admin


Joined: 15 Jun 2006
Posts: 1629
Location: Somewhere with lots of doors

PostPosted: Tue Feb 26, 2013 4:05 pm    Post subject: Reply with quote

As I said in the main thread I am voting YES


Walterohdim
_________________
Wannabee historian of Tinywarz. Through the building of myth we will build community. M. Scott Peck

Back to top
View user's profile Send private message Visit poster's website
krisjaniz
Mentor


Joined: 17 May 2009
Posts: 471

PostPosted: Thu Feb 28, 2013 2:52 am    Post subject: Reply with quote

Nobody could possibly have anything against it. The code is fishy but then again it kind of makes sense in a frizzy way. Without the time to really examine the code and set up some kind of a test environment to see if it works, I vote AYE. Maybe frizz can see if there's anything wrong with the code, I haven't read the full proces_turn.php to be certain myself.
_________________
Back to top
View user's profile Send private message
sirstephen
Hopeless Romantic


Joined: 01 Jun 2008
Posts: 181

PostPosted: Thu Feb 28, 2013 8:09 am    Post subject: Reply with quote

i like the idea, so unless someone from the community can come up with a good reason to disuade me, i vote Aye
Back to top
View user's profile Send private message AIM Address
Frizz
Site Admin


Joined: 10 Jun 2005
Posts: 3814

PostPosted: Sat Mar 02, 2013 2:52 pm    Post subject: Reply with quote

Interesting idea but to properly execute it you'd have to save-off the last level someone gained a merit at.

As this is coded, it increases the chances of merit gained for every level earned. Thus all crews will hit a level where they will always gain mertits.
_________________

Back to top
View user's profile Send private message
Slayer_666
Council Member


Joined: 20 Dec 2012
Posts: 226

PostPosted: Sat Mar 02, 2013 2:56 pm    Post subject: Reply with quote

Frizz wrote:
Interesting idea but to properly execute it you'd have to save-off the last level someone gained a merit at.

As this is coded, it increases the chances of merit gained for every level earned. Thus all crews will hit a level where they will always gain mertits.


Maybe we could have that, say the cap being level 25 -30?


Slayer
Back to top
View user's profile Send private message
Vanoi
Site Admin


Joined: 25 Aug 2005
Posts: 1403
Location: Avoiding You (The Void)

PostPosted: Tue Mar 05, 2013 2:58 pm    Post subject: Reply with quote

Recoded
_________________
The person who will go to great lengths to fight boredom...
Back to top
View user's profile Send private message Send e-mail MSN Messenger
krisjaniz
Mentor


Joined: 17 May 2009
Posts: 471

PostPosted: Tue Mar 05, 2013 3:05 pm    Post subject: Reply with quote

Vanoi wrote:
Recoded


Interesting.
What's the current process of modifying the actual SQL? I'm assuming we don't even know the current structure?
_________________
Back to top
View user's profile Send private message
krisjaniz
Mentor


Joined: 17 May 2009
Posts: 471

PostPosted: Tue Mar 05, 2013 7:55 pm    Post subject: Reply with quote

Vanoi wrote:
Recoded


Vanoi, hold your horses!

I am sorry I still don't have time to actually do anything or even read the actual code. That said I think the recode sucks.

1) I am assuming that crews which have 1-2 merits before the update will have NULL in m_level column. That means a level 20 crew with two merits will merit instantly. If we want that, fine. If we don't want that, when we encounter NULL in the m_level column we should set $meritlevel to the actual level the crew currently has and write that back to the database so that the crew gets a tiny bonus only the next time.

2) And now for the fun part - if we get a merit on a crew (ensuring that we have an m_level set in the database) and then remove some levels with a PU, we will get a crew that actually will have a far worse chance (an obvious understatement) of gaining a merit until we level it back to where it was. The bonus comes out negative in this case.
So a check has to be made if $meritlevel isn't actually bigger than the current level - if so it should be reset to the current level in the $meritlevel as well as the database.

Again - I haven't read the actual code outside the scope of this branch (?) so I urge you not to beat me up too bad if I have missed something. Laughing
_________________
Back to top
View user's profile Send private message
Vanoi
Site Admin


Joined: 25 Aug 2005
Posts: 1403
Location: Avoiding You (The Void)

PostPosted: Tue Mar 05, 2013 8:49 pm    Post subject: Reply with quote

Ahh... Yes I see your point...

I wasn't aware there were merits that reduced levels, that should be looked that though yes.

I'll tell Lark these concerns.
_________________
The person who will go to great lengths to fight boredom...
Back to top
View user's profile Send private message Send e-mail MSN Messenger
krisjaniz
Mentor


Joined: 17 May 2009
Posts: 471

PostPosted: Wed Mar 06, 2013 5:21 am    Post subject: Reply with quote

Vanoi wrote:
I'll tell Lark these concerns.


Also
Code:
$meritlevel =& $db->getone("SELECT m_level FROM crews WHERE crew_id=? ", array($weapon->i_on_unit["crew_id"]), DB_FETCHMODE_OBJECT);

should be
Code:
$meritlevel =& $db->getone("SELECT m_level FROM crews WHERE crew_id=? ", array($weapon->i_on_unit["crew_id"]));


Rolling Eyes

... but I'm probably doing it in the wrong thread and should rather shut up and mail Lark directly ...
_________________
Back to top
View user's profile Send private message
krisjaniz
Mentor


Joined: 17 May 2009
Posts: 471

PostPosted: Thu Mar 07, 2013 4:32 am    Post subject: Reply with quote

There's this one thing that's bothering me, maybe we can discuss it. If you use level remove PUs, the current code screws you over. The changes I suggested restore the status quo. But is it enough? If you get a merit at level 20 and then reduce the crew level to 10, should you start out with 0% meriting bonus or 50%? It's a small change in the code but a giant leap in the meriting efficiency. You will already get a greater chance to level the crew if you reduce those 10 levels, should you maybe also get a merit chance? I don't know.

Note that this meriting chance increase is valid for one merit only, then it is reset and you proceed as usual.
_________________
Back to top
View user's profile Send private message
Vanoi
Site Admin


Joined: 25 Aug 2005
Posts: 1403
Location: Avoiding You (The Void)

PostPosted: Thu Mar 07, 2013 8:18 am    Post subject: Reply with quote

I should reduce back to 0%, just think of it as any changes to merits would effect it.

Normally the counter would reset the last time you gained a merit, so it would increase if you leveled and failed a merit... in reverse you're remove levels without merits as well.
_________________
The person who will go to great lengths to fight boredom...
Back to top
View user's profile Send private message Send e-mail MSN Messenger
Display posts from previous:   
Post new topic   Reply to topic    Drop Shock Forum Index -> Player Council - Closed Tickets All times are GMT - 7 Hours
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © phpBB Group