FAQFAQ   SearchSearch   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

[Proposal] #74 - Merit Rework (Approved)
Goto page 1, 2  Next
 
Post new topic   Reply to topic    Drop Shock Forum Index -> Open Source
View previous topic :: View next topic  
Author Message
Larkable
Intermediate


Joined: 02 Jan 2010
Posts: 212

PostPosted: Tue Feb 26, 2013 1:34 am    Post subject: [Proposal] #74 - Merit Rework (Approved) Reply with quote

https://sourceforge.net/p/dropshock/tickets/74/

Every level that a crew gains past level 7 that does not result in a merit gives the crew an increased chance of 5% to merit.

Before this rework, if a crew rolled a merit that it already had, the merit would fail. Under this new system, there should not be a possible way to roll a merit that the unit already has in the first place. This means that a crew should no-longer fail a merit just because it already had that merit.
_________________


Last edited by Larkable on Sat Mar 09, 2013 5:37 pm; edited 1 time in total
Back to top
View user's profile Send private message
Stealth21
Elite


Joined: 21 Jul 2008
Posts: 3247
Location: philippines

PostPosted: Tue Feb 26, 2013 2:18 am    Post subject: Reply with quote

Me likey! Wink

A little change, more like a fix.
Do this noW!

_Chron
_________________
Back to top
View user's profile Send private message Yahoo Messenger
00don00
Advanced


Joined: 22 Aug 2008
Posts: 1208

PostPosted: Tue Feb 26, 2013 2:35 am    Post subject: Reply with quote

I like it.Support.
_________________
I've once defeated a brick wall in a game of tennis
I can also slam a revolving door
Back to top
View user's profile Send private message
Slayer_666
Council Member


Joined: 20 Dec 2012
Posts: 226

PostPosted: Tue Feb 26, 2013 2:36 am    Post subject: Reply with quote

It makes sense.

Support.

Slayer
Back to top
View user's profile Send private message
Walterohdim
Site Admin


Joined: 15 Jun 2006
Posts: 1629
Location: Somewhere with lots of doors

PostPosted: Tue Feb 26, 2013 5:51 am    Post subject: Reply with quote

This is a great idea. I hate training high level crews that just won't merit and there is no reason for this frustration. This proposal makes 100% sense. YES

Walterohdim
_________________
Wannabee historian of Tinywarz. Through the building of myth we will build community. M. Scott Peck

Back to top
View user's profile Send private message Visit poster's website
Larkable
Intermediate


Joined: 02 Jan 2010
Posts: 212

PostPosted: Tue Feb 26, 2013 5:53 am    Post subject: Reply with quote

Walterohdim wrote:
This proposal makes 100% sense. YES


Yay finally one of my ideas is good :D
_________________
Back to top
View user's profile Send private message
corclaork
Council Member


Joined: 26 Aug 2008
Posts: 518
Location: The Mohawk Wasteland

PostPosted: Tue Feb 26, 2013 6:51 am    Post subject: Reply with quote

support.

cor
_________________
"hit or be hit"

in game name : corclark
Back to top
View user's profile Send private message
Vanoi
Site Admin


Joined: 25 Aug 2005
Posts: 1403
Location: Avoiding You (The Void)

PostPosted: Tue Feb 26, 2013 9:06 am    Post subject: Reply with quote

Don't mean to call you out... but we need to talk about that code.
_________________
The person who will go to great lengths to fight boredom...
Back to top
View user's profile Send private message Send e-mail MSN Messenger
Larkable
Intermediate


Joined: 02 Jan 2010
Posts: 212

PostPosted: Tue Feb 26, 2013 9:14 am    Post subject: Reply with quote

Did I mess something up?
_________________
Back to top
View user's profile Send private message
Vanoi
Site Admin


Joined: 25 Aug 2005
Posts: 1403
Location: Avoiding You (The Void)

PostPosted: Tue Feb 26, 2013 9:18 am    Post subject: Reply with quote

Just some minor things.

#1, you're declaring the meritarray twice. Just declare it once at the top and delete the other one.

#2, you're unsetting it wrong. unset($allmerits,$meritarray);
_________________
The person who will go to great lengths to fight boredom...
Back to top
View user's profile Send private message Send e-mail MSN Messenger
Larkable
Intermediate


Joined: 02 Jan 2010
Posts: 212

PostPosted: Tue Feb 26, 2013 9:19 am    Post subject: Reply with quote

Vanoi wrote:
Just some minor things.

#1, you're declaring the meritarray twice. Just declare it once at the top and delete the other one.

#2, you're unsetting it wrong. unset($allmerits,$meritarray);


I'm muted, by the way.

Also, if you send me corrections over pastebin, I can fix it, commit it again, and edit the ticket.
_________________
Back to top
View user's profile Send private message
Larkable
Intermediate


Joined: 02 Jan 2010
Posts: 212

PostPosted: Tue Feb 26, 2013 9:47 am    Post subject: Reply with quote

Updated code to reflect Vanoi's changes.
_________________
Back to top
View user's profile Send private message
00don00
Advanced


Joined: 22 Aug 2008
Posts: 1208

PostPosted: Wed Feb 27, 2013 1:29 am    Post subject: Reply with quote

Please get this in the game asap.Would love to have those annoying high levels rotting in my storage finally be of some use.
_________________
I've once defeated a brick wall in a game of tennis
I can also slam a revolving door
Back to top
View user's profile Send private message
tomohawk
Advanced


Joined: 26 Sep 2009
Posts: 522
Location: Behind you!

PostPosted: Wed Feb 27, 2013 1:26 pm    Post subject: Reply with quote

Larkable wrote:
Walterohdim wrote:
This proposal makes 100% sense. YES


Yay finally one of my ideas is good Very Happy


Don't get used to it...

Support this though, this has been a bane to meriting for as long as I can remember
_________________
^this guy is crazy^
The Beatings Will Continue Until Morale Improves

Death before dishonor.

*not funny*
Back to top
View user's profile Send private message
Vanoi
Site Admin


Joined: 25 Aug 2005
Posts: 1403
Location: Avoiding You (The Void)

PostPosted: Thu Feb 28, 2013 8:12 am    Post subject: Reply with quote

This proposal has been approved.
_________________
The person who will go to great lengths to fight boredom...
Back to top
View user's profile Send private message Send e-mail MSN Messenger
Display posts from previous:   
Post new topic   Reply to topic    Drop Shock Forum Index -> Open Source All times are GMT - 7 Hours
Goto page 1, 2  Next
Page 1 of 2

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © phpBB Group