FAQFAQ   SearchSearch   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

#79 - [Tweak] Overcharge Shield versus PDS Effect (Added)
Goto page Previous  1, 2
 
Post new topic   Reply to topic    Drop Shock Forum Index -> Player Council - Closed Tickets
View previous topic :: View next topic  
Author Message
krisjaniz
Mentor


Joined: 17 May 2009
Posts: 471

PostPosted: Mon Mar 11, 2013 8:09 am    Post subject: Reply with quote

Vanoi wrote:
If you move the Shield Acti to where the PDS, then they would no longer effect combat for that turn... instead they would take effect next turn... That beats the point of an acti.

Like I said in my last post was well.... That regen for the second part can be removed... in fact that would probably be the better solution.


Yes, that would definitely be better. What you are actually doing is removing the shields cap from before the PDS/EMP and then enforcing it in the end after all is said and done. That's the way it should be, maximum support, AYE and yada yada yada...

Just don't try to do regen after PDS/EMP.
_________________
Back to top
View user's profile Send private message
Vanoi
Site Admin


Joined: 25 Aug 2005
Posts: 1403
Location: Avoiding You (The Void)

PostPosted: Mon Mar 11, 2013 7:48 pm    Post subject: Reply with quote

2nd Regen removed/recoded.
_________________
The person who will go to great lengths to fight boredom...
Back to top
View user's profile Send private message Send e-mail MSN Messenger
krisjaniz
Mentor


Joined: 17 May 2009
Posts: 471

PostPosted: Tue Mar 12, 2013 3:46 am    Post subject: Reply with quote

Vanoi wrote:
2nd Regen removed/recoded.


AYE.

Don't know if we need a revote but just in case saying AYE again.

Just a tiny nitpick, the code in red is not needed (but it can go in as is with no ill effect):
if (($unit["i_shields"] > $unit["i_shields_max"]) AND ($overShield == True)) {$unit["i_shields"] = $unit["i_shields_max"];}
_________________
Back to top
View user's profile Send private message
Vanoi
Site Admin


Joined: 25 Aug 2005
Posts: 1403
Location: Avoiding You (The Void)

PostPosted: Tue Mar 12, 2013 6:55 am    Post subject: Reply with quote

if ($unit["is_powered"] == "Y") {
if ($unit["i_shields"] < $unit["i_shields_max"]) {
$overShield = False;
if (isset($ae_shield_regen[($unit["c_sector"])][($userdata[($unit["i_owner"])]["i_faction"])])) { $shield_bonus = $ae_shield_regen[($unit["c_sector"])][($userdata[($unit["i_owner"])]["i_faction"])]; }
else {$shield_bonus = 0;}
$unit["i_shields"] += round($unit["i_shields_max"] * ($unit["i_shields_regen"] + $shield_bonus) * .01);
if ($unit["i_shields"] > $unit["i_shields_max"]) {$unit["i_shields"] = $unit["i_shields_max"];}
} else {$overShield = True;} }

Is not needed as well... it's just left over from when it was regen.
_________________
The person who will go to great lengths to fight boredom...
Back to top
View user's profile Send private message Send e-mail MSN Messenger
krisjaniz
Mentor


Joined: 17 May 2009
Posts: 471

PostPosted: Tue Mar 12, 2013 7:49 am    Post subject: Reply with quote

Vanoi wrote:
if ($unit["is_powered"] == "Y") {
if ($unit["i_shields"] < $unit["i_shields_max"]) {
$overShield = False;
if (isset($ae_shield_regen[($unit["c_sector"])][($userdata[($unit["i_owner"])]["i_faction"])])) { $shield_bonus = $ae_shield_regen[($unit["c_sector"])][($userdata[($unit["i_owner"])]["i_faction"])]; }
else {$shield_bonus = 0;}
$unit["i_shields"] += round($unit["i_shields_max"] * ($unit["i_shields_regen"] + $shield_bonus) * .01);
if ($unit["i_shields"] > $unit["i_shields_max"]) {$unit["i_shields"] = $unit["i_shields_max"];}
} else {$overShield = True;} }

Is not needed as well... it's just left over from when it was regen.


Good catch Laughing
_________________
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    Drop Shock Forum Index -> Player Council - Closed Tickets All times are GMT - 7 Hours
Goto page Previous  1, 2
Page 2 of 2

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © phpBB Group