FAQFAQ   SearchSearch   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

#30 - Faction Building Acti Fix (ADDED-CLOSED)

 
Post new topic   Reply to topic    Drop Shock Forum Index -> Open Source
View previous topic :: View next topic  
Author Message
khaibar
Advanced


Joined: 14 Dec 2007
Posts: 1141

PostPosted: Sat Dec 15, 2012 8:54 am    Post subject: #30 - Faction Building Acti Fix (ADDED-CLOSED) Reply with quote

Files: panel_unitinfo.php

There is a bug where u can't acti building actis (example sensor building deepview) on war planets

I believe the reason for this issue is the script only checking if player is owner not if player's faction is owner

Line 724
Code:
if ( ($data->c_type == "bld") AND ($data->i_owner == $userid) ) ) {


after

Code:
if ( ($data->c_type == "bld") AND (($data->i_owner == $userid) OR (($data->is_faction == "Y") AND ($data->i_faction == $data->userfaction))) ) {


add check if building is owned by faction and the user's faction is that faction then u can see stuff

note same fix may be needed in process_map too


ticket link: https://sourceforge.net/p/dropshock/tickets/30/
Back to top
View user's profile Send private message
snorok14
Advanced


Joined: 22 Aug 2008
Posts: 870
Location: Leave me alone, your mom and I are busy.

PostPosted: Sat Dec 15, 2012 8:46 pm    Post subject: Reply with quote

Pass it.
_________________
_D'z Nutz
Back to top
View user's profile Send private message
sirstephen
Hopeless Romantic


Joined: 01 Jun 2008
Posts: 181

PostPosted: Sat Dec 15, 2012 9:20 pm    Post subject: Reply with quote

passes from me
Back to top
View user's profile Send private message AIM Address
Dark Leth
Council Member


Joined: 05 Jul 2005
Posts: 1498

PostPosted: Sat Dec 15, 2012 11:31 pm    Post subject: Reply with quote

Support.
Back to top
View user's profile Send private message
Walterohdim
Site Admin


Joined: 15 Jun 2006
Posts: 1629
Location: Somewhere with lots of doors

PostPosted: Sun Dec 16, 2012 7:11 pm    Post subject: Reply with quote

Support
_________________
Wannabee historian of Tinywarz. Through the building of myth we will build community. M. Scott Peck

Back to top
View user's profile Send private message Visit poster's website
corclaork
Council Member


Joined: 26 Aug 2008
Posts: 518
Location: The Mohawk Wasteland

PostPosted: Sun Dec 16, 2012 7:28 pm    Post subject: Reply with quote

isn't it a bit redundant to vote on bug fix's?

ccor
_________________
"hit or be hit"

in game name : corclark
Back to top
View user's profile Send private message
Dark Leth
Council Member


Joined: 05 Jul 2005
Posts: 1498

PostPosted: Sun Dec 16, 2012 8:48 pm    Post subject: Reply with quote

corclaork wrote:
isn't it a bit redundant to vote on bug fix's?

ccor


We'll still ultimately approve the ticket probably so good for us to be transparent about the process - especially as some bug fixes (see the other proposal) might actually be effectively mechanics changes.
Back to top
View user's profile Send private message
khaibar
Advanced


Joined: 14 Dec 2007
Posts: 1141

PostPosted: Mon Dec 17, 2012 3:30 am    Post subject: Reply with quote

other proposal?
Back to top
View user's profile Send private message
Walterohdim
Site Admin


Joined: 15 Jun 2006
Posts: 1629
Location: Somewhere with lots of doors

PostPosted: Mon Dec 17, 2012 6:14 am    Post subject: Reply with quote

Pluss I just like saying Support Razz Cool Laughing Wink


Walterohdim
_________________
Wannabee historian of Tinywarz. Through the building of myth we will build community. M. Scott Peck

Back to top
View user's profile Send private message Visit poster's website
Dark Leth
Council Member


Joined: 05 Jul 2005
Posts: 1498

PostPosted: Mon Dec 17, 2012 7:45 am    Post subject: Reply with quote

khaibar wrote:
other proposal?


Buildings being returned to faction - it was never intended to work that way, therefore it is a mechanics change, despite nearly universal support and the naming of it as a bug fix.
Back to top
View user's profile Send private message
SpaceGhost
Mentor


Joined: 07 Sep 2007
Posts: 57

PostPosted: Thu Dec 27, 2012 10:49 am    Post subject: Reply with quote

Support
Thanks SpaceGhost
Back to top
View user's profile Send private message
Slayer_666
Council Member


Joined: 20 Dec 2012
Posts: 226

PostPosted: Thu Dec 27, 2012 2:15 pm    Post subject: Reply with quote

Support


Slayer
Back to top
View user's profile Send private message
Dark Leth
Council Member


Joined: 05 Jul 2005
Posts: 1498

PostPosted: Thu Dec 27, 2012 11:31 pm    Post subject: Reply with quote

This has passed with a majority of votes.
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    Drop Shock Forum Index -> Open Source All times are GMT - 7 Hours
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © phpBB Group